Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Crash in auth blocking function when using with phone auth #146

Merged
merged 3 commits into from
Oct 17, 2023

Conversation

savytskyi
Copy link
Contributor

@savytskyi savytskyi commented Oct 9, 2023

When using blocking function for phone auth, it crashes, because the dict does not seem to include "email_verified" param.

@google-cla
Copy link

google-cla bot commented Oct 9, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@savytskyi savytskyi changed the title Blocking login function: fixed crash on phone auth ("email_veried" is… Blocking login function: crashes when using with phone auth Oct 9, 2023
Copy link
Collaborator

@taeold taeold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing contribution - than k you so much.

@taeold taeold changed the title Blocking login function: crashes when using with phone auth fix: Crash in auth blocking function when using with phone auth Oct 10, 2023
@taeold taeold merged commit 5159a30 into firebase:main Oct 17, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants