fix the most egregious issue with the use of python logging #138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the Python 3.11 docs, emphasis added:
"""
debug(msg, *args, **kwargs)
Logs a message with level DEBUG on this logger. The msg is the message format string, and the args are the arguments which are merged into msg using the string formatting operator. (Note that this means that you can use keywords in the format string, together with a single dictionary argument.) No % formatting operation is performed on msg when no args are supplied.
"""
The simplest reproducible error case is:
python -c 'import logging; logging.warning("asdf", "qwer");'
The expected result is a stack trace.
To fix:
logger.warning("asdf %s", "qwer");
Please note that the firebase-functions-python codebase has a tremendous number of instances of this logging usage error. I'm only fixing the one that I encounter most frequently here, but it might be useful to perform a systematic review of the logging usage throughout the package.