Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FirestoreCache key type #1272

Merged
merged 24 commits into from
May 9, 2023
Merged

Update FirestoreCache key type #1272

merged 24 commits into from
May 9, 2023

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Apr 14, 2023 •
edited
Loading

Update the FirestoreCache key from App* to std::pair<App*, std::string>, to support multiDB firestore caching.

@milaGGL milaGGL self-assigned this Apr 18, 2023
@milaGGL milaGGL changed the title debugging the memory error Update FirestoreCache key type Apr 18, 2023
@milaGGL milaGGL marked this pull request as ready for review April 19, 2023 20:52
@milaGGL milaGGL requested a review from tom-andersen April 19, 2023 20:52
tom-andersen
tom-andersen requested changes May 3, 2023
View reviewed changes
firestore/integration_test_internal/src/firestore_test.cc Outdated Show resolved Hide resolved
firestore/integration_test_internal/src/firestore_integration_test.h Show resolved Hide resolved
firestore/integration_test_internal/src/firestore_test.cc Show resolved Hide resolved
firestore/integration_test_internal/src/firestore_test.cc Outdated Show resolved Hide resolved
firestore/integration_test_internal/src/firestore_test.cc Outdated Show resolved Hide resolved
firestore/integration_test_internal/src/validation_test.cc Show resolved Hide resolved
firestore/integration_test_internal/src/validation_test.cc Show resolved Hide resolved
firestore/integration_test_internal/src/validation_test.cc Show resolved Hide resolved
firestore/src/common/firestore.cc Outdated Show resolved Hide resolved
firestore/src/common/firestore.cc Outdated Show resolved Hide resolved
@milaGGL milaGGL requested a review from tom-andersen May 8, 2023 18:52
@milaGGL milaGGL merged commit 3c2dc25 into mila/MultiDB May 9, 2023
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label May 9, 2023
@github-actions
Copy link

github-actions bot commented May 9, 2023 •
edited
Loading

❌  Integration test FAILED

Requested by @milaGGL on commit 3c2dc25
Last updated: Tue May 9 10:44 PDT 2023
View integration test log & download artifacts

Failures Configs
firestore
(6 items)[BUILD] [ERROR] [Android] [All 3 os]
[TEST] [ERROR] [Linux] [x64] [openssl]
[TEST] [ERROR] [MacOS] [x64] [openssl]
[TEST] [ERROR] [iOS] [macos] [All 2 ios_device]
[TEST] [ERROR] [tvOS] [macos] [tvos_simulator]
[TEST] [FAILURE] [Windows] [x64] [openssl]
(3 failed tests)  ValidationTest.DifferentFirestoreGetInstanceCanGetSameDefaultFirestoreInstance
  ValidationTest.DifferentFirestoreGetInstanceWithSameDatabaseNameShouldGetSameFirestoreInstance
  ValidationTest.FirestoreGetInstanceCalledMultipleTimeReturnSameInstance

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label May 9, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 9, 2023
@firebase firebase locked and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tom-andersen tom-andersen tom-andersen approved these changes

Assignees

@tom-andersen tom-andersen

@milaGGL milaGGL

Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milaGGL @tom-andersen