Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass database_id from GetInstance() down to CreateFirestore() #1270

Merged
merged 4 commits into from
Apr 14, 2023
Merged

Pass database_id from GetInstance() down to CreateFirestore() #1270

merged 4 commits into from
Apr 14, 2023

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Apr 13, 2023 •
edited
Loading

Passing database_id as an additional parameter all the way down to iOS CreateFirestore function.
Passing the database_id parameter only, no implementation change yet.

@milaGGL milaGGL added the skip-release-notes Skip release notes check label Apr 13, 2023
@milaGGL milaGGL self-assigned this Apr 13, 2023
@milaGGL milaGGL requested a review from tom-andersen April 13, 2023 23:05
tom-andersen
tom-andersen requested changes Apr 14, 2023
View reviewed changes
firestore/src/include/firebase/firestore.h Show resolved Hide resolved
firestore/src/main/firestore_main.h Outdated Show resolved Hide resolved
firestore/src/main/firestore_main.h Outdated Show resolved Hide resolved
@milaGGL milaGGL requested a review from tom-andersen April 14, 2023 16:47
tom-andersen
tom-andersen approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@tom-andersen tom-andersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@milaGGL milaGGL merged commit 6a9e36b into mila/MultiDB Apr 14, 2023
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Apr 14, 2023
@github-actions
Copy link

github-actions bot commented Apr 14, 2023 •
edited
Loading

❌  Integration test FAILED

Requested by @milaGGL on commit 6a9e36b
Last updated: Fri Apr 14 12:50 PDT 2023
View integration test log & download artifacts

Failures Configs
firestore [BUILD] [ERROR] [Android] [All 3 os]

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Apr 14, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 14, 2023
@firebase firebase locked and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tom-andersen tom-andersen tom-andersen approved these changes

Assignees

@milaGGL milaGGL

Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milaGGL @tom-andersen