Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mila/multi db add get instance header #1267

Merged
merged 3 commits into from
Apr 13, 2023
Merged

Mila/multi db add get instance header #1267

merged 3 commits into from
Apr 13, 2023

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Apr 12, 2023

Add 2 overloading methods to the firestore.h file, as proposed in Firestore Multi Database API Proposal:

static Firestore* GetInstance(const char* db_name,
                              InitResult* init_result_out = nullptr);
static Firestore* GetInstance(::firebase::App* app,
                              const char* db_name,
                              InitResult* init_result_out = nullptr);

This is only a definition, actual implementation will be pushed up in following PRs.

@milaGGL milaGGL self-assigned this Apr 12, 2023
@milaGGL milaGGL changed the base branch from main to mila/MultiDB April 12, 2023 23:03
@milaGGL milaGGL added the skip-release-notes Skip release notes check label Apr 12, 2023
@milaGGL milaGGL requested a review from tom-andersen April 12, 2023 23:22
@milaGGL milaGGL merged commit bd7a8df into mila/MultiDB Apr 13, 2023
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Apr 13, 2023
@github-actions
Copy link

github-actions bot commented Apr 13, 2023 •
edited
Loading

✅  Integration test succeeded!

Requested by @milaGGL on commit bd7a8df
Last updated: Thu Apr 13 11:27 PDT 2023
View integration test log & download artifacts

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Apr 13, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 13, 2023
@firebase firebase locked and limited conversation to collaborators May 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tom-andersen tom-andersen tom-andersen approved these changes

Assignees

@milaGGL milaGGL

Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milaGGL @tom-andersen