Cancel callbacks for messaging (#745)

* Cancel callbacks for messaging util::Terminate is referenced counted som when there ar more APIs than messaging active the callbacks will not be canceled until later and still cause a NULL ref due to the FutureData being destroyed now. * Cancel callback earlier * Update readme
firebase · Nov 18, 2021 · 618a317 · 618a317
1 parent a219a97
commit 618a317
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/messaging/src/android/cpp/messaging.cc b/messaging/src/android/cpp/messaging.cc
@@ -677,6 +677,7 @@ void Terminate() {
   }
   internal::UnregisterTerminateOnDefaultAppDestroy();
   JNIEnv* env = g_app->GetJNIEnv();
+  util::CancelCallbacks(env, kApiIdentifier);
   // Dereference the app.
   {
     MutexLock lock(g_app_mutex);

diff --git a/release_build_files/readme.md b/release_build_files/readme.md
@@ -577,6 +577,8 @@ code.
         ([#737](https://github.com/firebase/firebase-cpp-sdk/issues/737))
     -   Messaging (Android): Fixed crash during termination.
         ([#739](https://github.com/firebase/firebase-cpp-sdk/pull/739))
+        ([#745](https://github.com/firebase/firebase-cpp-sdk/pull/745))
+
 
 ### 8.7.0
 -   Changes