-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make AQS resilient to background init in multi-process apps #6699
Conversation
Release note changesThe following had changelogs that were modified, but did not have any unreleased entries for release notes to generate from. Changelogsfirebase-sessions |
Coverage Report 1Affected Products
Test Logs |
Test Results 38 files - 996 38 suites - 996 56s ⏱️ - 33m 49s Results for commit 59e6201. ± Comparison against base commit 263fbc0. This pull request removes 5794 tests.
|
Size Report 1Affected Products
Test Logs |
Make AQS resilient to background init in multi-process apps. This deals with a case where a customer manually initializes Firebase in a background thread in a multi-process app. See #6599. There is a race condition and it becomes possible for AQS to access the
FirebaseApp
instance before Firebase has finished initializing in that process.This just prevents the crash. A better solution would be to use Dagger for proper dependency injection instead of relying on the Firebase Components. See https://firebase.github.io/firebase-android-sdk/best_practices/dependency_injection.