Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ndk build. #4311

Merged
merged 2 commits into from
Nov 11, 2022
Merged

Fix ndk build. #4311

merged 2 commits into from
Nov 11, 2022

Conversation

vkryachko
Copy link
Member

Due to AGP upgrade the crashlytics-trampoline.so file stopped being included in the resulting AAR, this causes issues on devices with api 29+.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@vkryachko
Fix ndk build.
be8259b 
Due to AGP upgrade the crashlytics-trampoline.so file stopped being
included in the resulting AAR, this causes issues on devices with api
29+.
@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2022 •
edited
Loading

buildSrc Test Results

18 tests   18 ✔️  1m 37s ⏱️
  4 suites    0 💤
  4 files      0 ❌

Results for commit 6f8a147.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 11, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-crashlytics-ndk

    TypeBase (d719e10)Merge (1fc0a32)Diff
    aar1.67 MB1.68 MB+13.9 kB (+0.8%)
    apk (aggressive / arm64-v8a)1.33 MB1.34 MB+12.4 kB (+0.9%)
    apk (aggressive / armeabi-v7a)838 kB846 kB+8.28 kB (+1.0%)
    apk (aggressive / x86)1.38 MB1.38 MB+8.27 kB (+0.6%)
    apk (aggressive / x86_64)1.43 MB1.45 MB+12.4 kB (+0.9%)
    apk (release / arm64-v8a)2.00 MB2.02 MB+12.4 kB (+0.6%)
    apk (release / armeabi-v7a)1.51 MB1.52 MB+8.28 kB (+0.5%)
    apk (release / x86)2.05 MB2.06 MB+8.27 kB (+0.4%)
    apk (release / x86_64)2.11 MB2.12 MB+12.4 kB (+0.6%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/AmKfndSA03.html

@vkryachko vkryachko merged commit 3aac867 into master Nov 11, 2022
@vkryachko vkryachko deleted the vk.ndk_fix branch November 11, 2022 18:42
@mrober mrober mentioned this pull request Nov 11, 2022
Closed
davidmotson pushed a commit that referenced this pull request Nov 28, 2022
@vkryachko
Fix ndk build. (#4311)
102c3db 
* Fix ndk build.

Due to AGP upgrade the crashlytics-trampoline.so file stopped being
included in the resulting AAR, this causes issues on devices with api
29+.

* fix filename
@firebase firebase locked and limited conversation to collaborators Dec 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kmandrika kmandrika kmandrika approved these changes

@mrober mrober mrober approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vkryachko @google-oss-bot @kmandrika @mrober