-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset backoff when connectivity status changes #1706
Conversation
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (4a18b5b6) is created by Prow via merging commits: 0eaca5e 9dd1288. |
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (4a18b5b6) is created by Prow via merging commits: 0eaca5e 9dd1288. |
/test smoke-tests |
Verified via Fireeats. |
firebase-firestore/CHANGELOG.md
Outdated
@@ -1,4 +1,7 @@ | |||
# Unreleased | |||
- [fixed] Removed a delay that may have prevented Firestore from immediately | |||
establishing a network connection if a connectivity change occurred while |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: perhaps s/establishing/reestablishing/?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@schmidt-sebastian: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Merging as this seems to hit a build problem in the current tests. |
Port of firebase/firebase-ios-sdk#5857