Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset backoff when connectivity status changes #1706

Merged
merged 8 commits into from
Jun 24, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

@googlebot googlebot added the cla: yes Override cla label Jun 23, 2020
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 23, 2020

Binary Size Report

Affected SDKs

  • firebase-common

    Type Base (0eaca5e) Head (4a18b5b6) Diff
    apk (aggressive) 82.7 kB 82.7 kB +4 B (+0.0%)
    apk (debug) 772 kB 772 kB -3 B (-0.0%)
  • firebase-components

    Type Base (0eaca5e) Head (4a18b5b6) Diff
    apk (aggressive) 11.0 kB 11.0 kB +5 B (+0.0%)
    apk (debug) 35.8 kB 35.8 kB +3 B (+0.0%)
  • firebase-database-collection

    Type Base (0eaca5e) Head (4a18b5b6) Diff
    apk (aggressive) 314 kB 314 kB -2 B (-0.0%)
    apk (debug) 1.07 MB 1.07 MB -42 B (-0.0%)
  • firebase-firestore

    Type Base (0eaca5e) Head (4a18b5b6) Diff
    aar 996 kB 996 kB +18 B (+0.0%)
    apk (aggressive) 461 kB 461 kB +4 B (+0.0%)
    apk (debug) 3.79 MB 3.79 MB +118 B (+0.0%)
    apk (release) 3.16 MB 3.15 MB -84 B (-0.0%)
  • protolite-well-known-types

    Type Base (0eaca5e) Head (4a18b5b6) Diff
    apk (debug) 768 kB 768 kB +3 B (+0.0%)

Test Logs

Notes

Head commit (4a18b5b6) is created by Prow via merging commits: 0eaca5e 9dd1288.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 23, 2020

Coverage Report

Affected SDKs

  • firebase-firestore

    SDK overall coverage changed from 46.71% (0eaca5e) to 46.71% (4a18b5b6) by +0.01%.

    Filename Base (0eaca5e) Head (4a18b5b6) Diff
    RemoteStore.java 92.08% 92.15% +0.07%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (4a18b5b6) is created by Prow via merging commits: 0eaca5e 9dd1288.

@schmidt-sebastian
Copy link
Contributor Author

/test smoke-tests

@schmidt-sebastian
Copy link
Contributor Author

Verified via Fireeats.

@@ -1,4 +1,7 @@
# Unreleased
- [fixed] Removed a delay that may have prevented Firestore from immediately
establishing a network connection if a connectivity change occurred while
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: perhaps s/establishing/reestablishing/?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@google-oss-bot
Copy link
Contributor

@schmidt-sebastian: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests 9dd1288 link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@schmidt-sebastian
Copy link
Contributor Author

Merging as this seems to hit a build problem in the current tests.

@schmidt-sebastian schmidt-sebastian merged commit 751684d into master Jun 24, 2020
schmidt-sebastian added a commit to firebase/firebase-js-sdk that referenced this pull request Jun 24, 2020
@firebase firebase locked and limited conversation to collaborators Jul 25, 2020
@kaibolay kaibolay deleted the mrschmidt/reconnect branch September 14, 2022 17:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants