Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rc): Sever Side Remote Config Integration #863

Merged
merged 7 commits into from
Mar 5, 2025
Merged

feat(rc): Sever Side Remote Config Integration #863

merged 7 commits into from
Mar 5, 2025

Conversation

pijushcs
Copy link
Contributor

@pijushcs pijushcs commented Feb 12, 2025

Discussion
Added support for Server Side Remote Config in Python Admin SDK. This feature allows developers to dynamically
manage the behavior and configuration of server applications using Python.

API Changes
Incrementally reviewed via ssrc-prefixed feature branches.

pijushcs and others added 5 commits February 13, 2025 02:09
* Initial Skeleton for SSRC Implementation

* Adding Implementation for RemoteConfigApiClient and ServerTemplate APIs

* Updating API signature

* Minor update to API signature

* Adding comments and unit tests

* Updating init params for ServerTemplateData

* Adding validation errors and test

* Adding unit tests for init_server_template and get_server_template

* Removing parameter groups

* Addressing PR comments and fixing async flow during fetch call

* Fixing lint issues

---------

Co-authored-by: Pijush Chakraborty <pijushc@google.com>
…e Remote Config (#824)

* Added implemenation of evaluate function

* Improvement

* Add farmhash to extension whitelist pkg

* Replace farmhash to hashlib

* Added unit testcase

* removed lint error

* add mock test

* resolve lint comments

* Fixed bug

* Added fixes

* Added fixe

* Added fix for lint

* Changed structure of test

* Added fix for comments

* Added fix for comments

---------

Co-authored-by: Varun Rathore <varunrathore@google.com>
* Changes for percent comparison

* Fixing semantic version issues with invalid version

* Fixing Config values must retrun default values from invalid get operations

* Updating tolerance for percentage evaluation

* Removing dependency changes from fix branch

* Updating ServerConfig methods as per review changes

* Updating comments and vars for readability

* Added unit and integration tests

* Refactor and add unit test

* Implementation for Fetching and Caching Server Side Remote Config (#825)

* Minor update to API signature

* Updating init params for ServerTemplateData

* Adding validation errors and test

* Removing parameter groups

* Addressing PR comments and fixing async flow during fetch call

* Fixing lint issues

---------

Co-authored-by: Jonathan Edey <145066863+jonathanedey@users.noreply.github.com>
Co-authored-by: Lahiru Maramba <llahiru@gmail.com>
Co-authored-by: Pijush Chakraborty <pijushc@google.com>
Co-authored-by: varun rathore <35365856+rathovarun1032@users.noreply.github.com>
Co-authored-by: Varun Rathore <varunrathore@google.com>
…d the value source of the config values (#850)

* Updating ServerTemplate to accomodate to_json() method

* Updating unit tests and docstrings

* Adding re-entrant lock to make template cache updates/reads atomic

---------

Co-authored-by: Pijush Chakraborty <pijushc@google.com>
* Fixing percentage lowebound issues

* Updating logs

* Fixing lint issues

---------

Co-authored-by: Pijush Chakraborty <pijushc@google.com>
@lahirumaramba lahirumaramba changed the title Sever Side Remote Config Integration feat(rc): Sever Side Remote Config Integration Feb 12, 2025
@lahirumaramba lahirumaramba added release-note release:stage Stage a release candidate labels Feb 12, 2025
Fixed  typos in comments and added additional description
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's trigger staging before we merge this. Thanks!

@pijushcs pijushcs merged commit cc9a069 into master Mar 5, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:stage Stage a release candidate release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants