chore: Added Actions-based release workflow #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahirumaramba
approved these changes
Feb 19, 2020
| # Only run the workflow when a PR is merged to the master branch. | ||
| pull_request: | ||
| branches: master | ||
| types: closed |
There was a problem hiding this comment.
If we close a PR without merging would that also trigger this?
There was a problem hiding this comment.
It does, but then will get immediately skipped because of:
if: github.event.pull_request.merged
hiranya911
added a commit
that referenced
this pull request
Apr 23, 2020
* chore: Removed Travis CI integration (#326) * chore: Added Actions-based release workflow (#331) * chore: Added Actions-based release workflow * Set GOPATH * Fixed working directory for tests * Decrypting credentials into the testdata directory * Added preflight and post check scripts * chore: Running CI workflow on pull_request (#338) * fix(fcm): correct the iidEndpoint endpoints used for topic management (#335) According to the document https://developers.google.com/instance-id/reference/server, the endpoints should be: https://iid.googleapis.com/iid/v1:batchAdd https://iid.googleapis.com/iid/v1:batchRemove NOT: https://iid.googleapis.com/iid/v1/:batchAdd https://iid.googleapis.com/iid/v1/:batchRemove * fix(fcm): Fix documents of FCM batch request limit (#347) Co-authored-by: Hiranya Jayathilaka <hiranya911@gmail.com> * fix: Deferring credential loading until required (#361) * Bumped version to 3.12.1 (#363) * chore: Specifying correct working directory for staging command (#365) Co-authored-by: Rueian <rueiancsie@gmail.com> Co-authored-by: 178inaba <178inaba.git@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to take a slightly different approach with Go releases since there are no artifacts to speak of. The proposed release process is:
release:stage. This will trigger the staging workflow and run the tests. (Actually the label is optional in this case. Simply targeting the master branch is sufficient)Sample staging run: https://github.com/firebase/firebase-admin-go/runs/439827992