Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New snippet with project id defined. #358

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

pwujczyk
Copy link
Contributor

@pwujczyk pwujczyk commented Aug 9, 2023

In the internal bug b/290344815 we had been discussing how to initialize SDK and we come up with working version which is different than documentation on the page: https://firebase.google.com/docs/admin/setup?hl=pl#initialize_the_sdk_in_non-google_environments.

This is only part of the change. The second part is done in cider. cl/555243967

In the internal bug b/290344815 we had been discussing how to initialize SDK and we come up with working version which is different than documentation on the page: https://firebase.google.com/docs/admin/setup?hl=pl#initialize_the_sdk_in_non-google_environments
@google-cla
Copy link

google-cla bot commented Aug 9, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM. Please sign the CLA.

@pwujczyk
Copy link
Contributor Author

done.

Copy link

@Xiaoshouzi-gh Xiaoshouzi-gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the new snippet!

@lahirumaramba lahirumaramba merged commit 0456d5b into firebase:master Aug 11, 2023
4 checks passed
@pwujczyk pwujczyk deleted the b_290344815 branch August 15, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants