-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncomment the Obsolete
tags for deprecated FCM batch send APIs
#355
Conversation
a8575f7
to
47eb28c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Doris-Ge ! Added a comment.
@@ -124,78 +124,6 @@ public async Task SendEachForMulticast() | |||
Assert.NotNull(response.Responses[1].Exception); | |||
} | |||
|
|||
[Fact] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to remove this test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Because now SendAllAsync
and SendMulticastAsync
have been marked as obsolete, these two integration tests will fail: https://github.com/firebase/firebase-admin-dotnet/actions/runs/5661155177/job/15338452380 .
I also tried marking these two tests with "[Ignore]", but it could not build. Any suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Okay, let's remove them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -124,78 +124,6 @@ public async Task SendEachForMulticast() | |||
Assert.NotNull(response.Responses[1].Exception); | |||
} | |||
|
|||
[Fact] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Okay, let's remove them.
Will you build a new package soon which has these obsolete tags? |
Address the issue flagged in #349