This repository has been archived by the owner on Jul 18, 2022. It is now read-only.
Plugin API #43
Merged
Plugin API #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PerchunPak
reviewed
Mar 11, 2022
PerchunPak
suggested changes
Mar 21, 2022
|
|
||
| Arguments: | ||
| app: Application instance | ||
| config: Config instance |
There was a problem hiding this comment.
А я не работаю в гугле)
| """ | ||
| self.app = app | ||
| self.config = config | ||
| self.log = get_logger(self.__class__.__name__) |
There was a problem hiding this comment.
Ты же его по файлам разделяешь, не по классам.
There was a problem hiding this comment.
В других логгерах я поменял на классы, для читаемости и эстатичности
There was a problem hiding this comment.
По файлам был перебор, а тут... У нас для каждого класса свой файл, зачем еще больше разделять? Хотя... это убирает инициализацию логгера при импорте.
There was a problem hiding this comment.
Да, да, давая всё в __init__.py хуячить!
PerchunPak
added
enhancement
PerchunPak
suggested changes
Mar 22, 2022
| log.info("Enabling `%s`..." % plugins_path) | ||
| plugins_module = import_module(plugins_path) | ||
| if "setup" in plugins_module.__dir__(): | ||
| if plugins_module.__api_version__ != 1: |
There was a problem hiding this comment.
TODO мне: переделать ifы в класс с цепочкой обработчиков (паттерн Цепочка обязанностей)
| log = get_logger("PluginManager") | ||
|
|
||
|
|
||
| def initialize_all() -> None: |
There was a problem hiding this comment.
Переделай пожалуйста эту функцию в класс, для более легкого тестирования.
Because it's more understandable
PerchunPak
reviewed
Mar 23, 2022
cofob
added a commit
that referenced
this pull request
Apr 12, 2022
* aiohttp init * Add changes to CHANGELOG.md * Change `import ?` to `from ? import ?` * Change branch `master` to `aiohttp` * Fix CI * Move ifmain block to function (#27) * Change poetry installation (#26) * Change poetry installation * Fix typo in word * Add script to remove residual trash (#28) * Port logger from django branch 🚚 (#30) * Port logger from django branch 🚚 * Add log levels * Add @PerchunPak suggestions * Add LOG_SEPARATE and LOG_PATH features * Sync `pyproject.toml` and `docs/requirments.txt` This fix `readthedocs` build. * Remove Python3.11 from CICD (#37) * Remove Python3.11 from CICD * Add changes from PR to CHANGELOG.md * Apply codestyle ✏️ [skip ci] * Update poetry.lock 📈 * Fix typo in poetry command * Port Config class from `master` (#38) * Port Config class from `master` * Add Singleton to Config class * Make `furo` auto-updateble * Update poetry.lock 📈 * Fix Docker container build * Update poetry.lock 📈 * Fix CI pushing in pull requests (cherry picked from commit 54b39e2) * Final fix CI pushing in pull requests (cherry picked from commit e6ab8df) * Update poetry.lock 📈 * Plugin API (#43) * Add base aiohttp sub-apps initialization * Add mako as templating language * Fix VSC config for Win * Type init func * Update [skip ci] * DL VSC folder * DL app view * Add plugin initialization * TLTD * Fix tests * Private methods can start with one _ * Rename variable `e` to `exception` * Change `pip freeze` to `pip list` Because it's more understandable * Remove necessary checks Co-authored-by: PerchunPak <perchunpak@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Важный check-list
CHANGELOG.mdи добавил номер PR туда.make testи с тех пор ничего не менял.