Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close stdin / stdout / stderr in child process after fork #7

Merged
merged 3 commits into from
Apr 14, 2016
Merged

Close stdin / stdout / stderr in child process after fork #7

merged 3 commits into from
Apr 14, 2016

Commits on Apr 14, 2016

  1. Close stdin / stdout / stderr in child process after fork 

    This seems to be necessary to detach from the pseudo tty when running in
background. I did the minimal change that seems to fix our issue, but other
changes might be useful as well here (setsid, redirect stdout/stderr to /dev/null),
etc.
    Tudor Golubenco committed Apr 14, 2016
    Configuration menu
    Copy the full SHA
    2c4f0f0 View commit details
    Browse the repository at this point in the history

  2. Stat the file to execute to report errors early 

    Also check if it's executable. The check for executable succeeds if
any of user, group or other has the x flag set.

Note that this change means that the executable must be passed with the
full path.
    Tudor Golubenco committed Apr 14, 2016
    Configuration menu
    Copy the full SHA
    757c8c1 View commit details
    Browse the repository at this point in the history

  3. Changed error message in case x flag is missing

    Tudor Golubenco committed Apr 14, 2016
    Configuration menu
    Copy the full SHA
    4890bd4 View commit details
    Browse the repository at this point in the history