FIPs 36-40 changes to fio.contracts #269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FIP-37 remove keys restrictions
added 8 commits
July 26, 2022 13:56
FIP-38 first dev iteration
FIP-39 add and info table and row type
FIP-39 add endpount and action for update_encrypt_key.
FIP-39 do the table update, dev tested and verified this works as expected.
FIP-39 integrate handle info into regaddress, xferaddress, burnaddress
FIP-39 comments for coding
FIP-39 fix bug found during dev test
FIPs36-40 error message analysis
ericbutz
requested changes
Jan 20, 2023
| @@ -792,6 +845,13 @@ | |||
| ], | |||
| "type": "fioname" | |||
| }, | |||
| { | |||
| "name": "handleinfo", | |||
There was a problem hiding this comment.
We use "address" instead of "handle" elsewhere in the code. It could be confusing to introduce a new term. Plus, it is of type "fioname_info_item".
Suggest "fionameinfo"
added 4 commits
January 21, 2023 11:06
FIPs36-40 code review items
Fips 36-40 code review feedback
…ons present FIP-39 add logic to handle update when there are other data descriptions present
FIPs 36-40 remove old note
adsorptionenthalpy
approved these changes
Jan 26, 2023
|
Transferred to clean PR: #288 Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch will be used for all changes for FIPs 36 -40 please do not merge until all FIPs are completed and verified by QA.