Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new functional mapper to create a shared data store #254

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

yinan-symphony
Copy link
Contributor

Create a shared data store, so that the shared data is accessible among the process instances and also among the different workflows.

The shared data is grouped by its namespace, the key of the data must be unique in its namespace, but could be duplicate in different namespace.

Description

Please put here the intent of your pull request.

Dependencies

List the other pull requests that should be merged before/along this one.

Checklist

  • Referenced a ticket in the PR title or description
  • Filled properly the description and dependencies, if any
  • Unit/Integration tests updated or added
  • Javadoc added or updated
  • Updated the documentation in docs folder

public class SharedDataIntegrationTest extends IntegrationTest {

@Test
@DisplayName("Share counter between process instances")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need another test where the counter is shared between 2 separate workflows.

Copy link
Contributor

@symphony-soufiane symphony-soufiane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update the doc with the 2 new introduced utility functions:
https://github.com/finos/symphony-wdk/blob/master/docs/reference.md#utility-functions

@yinan-symphony yinan-symphony force-pushed the feature/shared-data branch 6 times, most recently from efcab77 to b1407f3 Compare April 14, 2023 17:42
Create a shared data store, so that the shared data is accessible among
the process instances and also among the different workflows.

The shared data is grouped by its namespace, the key of the data must be
unique in its namespace, but could be duplicate in different namespace.
@yinan-symphony yinan-symphony merged commit 7a45422 into finos:master Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants