Fix response code when trying to update a published workflow #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error message returned when trying to update a workflw that has an already published version was confusing at it says that the workflow does not exist. THis has been fixed in this PR by firstly checking if the workflos exists, then returning a more detailed exception when a version is already published.
...ow-bot-app/src/main/java/com/symphony/bdk/workflow/management/WorkflowManagementService.java
Show resolved
Hide resolved
ystxn
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The error message returned when trying to update a workflow that has an already published version was confusing at it says that the workflow does not exist. Ths has been fixed in this PR by firstly checking if the workflow exists, then returning a more detailed exception when a version is already published.