Add silent flag to update message activity #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yinan-symphony
force-pushed
the
feature/silent-message-update
branch
from
3387921 to
4873735
Compare
docs/reference.md
Outdated
| @@ -861,7 +861,8 @@ Update an existing message into a stream. Returns the new updated message. | |||
| Key | Type | Required | | |||
| ------------ | -------| --- | | |||
| [message-id](#update-message-id) | String | Yes | | |||
| [content](#content) | String/Object| Yes | | |||
| [content](#content) | String/Object | Yes | | |||
| silent | Boolean | No | | |||
There was a problem hiding this comment.
Can you describe "silent" property, and link it here ([silent](# silent)) ?
| } | ||
|
|
||
| @Test | ||
| void updateMessageWithTemplateSuccessfull() throws IOException, ProcessingException { | ||
| void updateMessageWithoutSilentSuccessfully() throws IOException, ProcessingException { |
There was a problem hiding this comment.
can we use ParameterizedTest for the two tests? The argument would be the workflow file path and the expected "silent" boolean value.
yinan-symphony
force-pushed
the
feature/silent-message-update
branch
5 times, most recently
from
3588112 to
402e43b
Compare
The silent flag in the update message service was included in the new BDK release, this commit is to support the same in WDK.
yinan-symphony
force-pushed
the
feature/silent-message-update
branch
from
402e43b to
3415817
Compare
| @@ -18,6 +18,9 @@ | |||
|
|
|||
| import com.github.fge.jsonschema.core.exceptions.ProcessingException; | |||
| import org.junit.jupiter.api.Test; | |||
| import org.junit.jupiter.params.ParameterizedTest; | |||
| import org.junit.jupiter.params.provider.CsvSource; | |||
| import org.junit.jupiter.params.provider.MethodSource; | |||
There was a problem hiding this comment.
I think this import is not used
symphony-soufiane
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The silent flag in the update message service was included
in the new BDK release, this commit is to support the same
in WDK.
Description
Please put here the intent of your pull request.
Dependencies
List the other pull requests that should be merged before/along this one.
Checklist