-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few CSS fixes for regular-table in shadow DOM #2526
Merged
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
23ac709
Move regular-table theme variables to higher-scoped rule
tomjakubowski 4d6b487
Fix CSS bug in mitered headers
tomjakubowski 057845f
Fix related CSS bugs in shadow dom
tomjakubowski ce9217d
Fix missing border when sidebar open
tomjakubowski bddc5b6
Clarify TODOs
tomjakubowski e644cef
datagrid: guard shadow DOM behind feature detection
tomjakubowski f0e7a60
Handle light/shadow DOM split more robustly
tomjakubowski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -60,17 +60,19 @@ perspective-string-column-style[theme="Monokai"] { | |
} | ||
|
||
@mixin perspective-viewer-monokai--datagrid { | ||
regular-table { | ||
--rt-pos-cell--color: #78dce8 !important; | ||
--rt-neg-cell--color: #ff6188 !important; | ||
--rt--border-color: #444444; | ||
} | ||
--rt-pos-cell--color: #78dce8 !important; | ||
--rt-neg-cell--color: #ff6188 !important; | ||
--rt--border-color: #444444; | ||
|
||
// FIXME: broken in shadow DOM. Can be fixed with a new custom property allowing empty header cell backgrounds | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I took a stab at this, but I couldn't work out how to declare the "default" value for the CSS custom property so that the theme override's was more specific than it |
||
// to be styled | ||
regular-table table tbody th:empty { | ||
background: linear-gradient(to right, | ||
transparent 9px, | ||
#444444 10px, | ||
transparent 11px); | ||
background: linear-gradient( | ||
to right, | ||
transparent 9px, | ||
#444444 10px, | ||
transparent 11px | ||
); | ||
} | ||
} | ||
|
||
|
@@ -97,7 +99,9 @@ perspective-string-column-style[theme="Monokai"] { | |
|
||
--d3fc-negative--gradient: linear-gradient(#272822 0%, #ff6188 100%); | ||
--d3fc-positive--gradient: linear-gradient(#272822 0%, #78dce8 100%); | ||
--d3fc-full--gradient: linear-gradient(#ff6188 0%, | ||
#272822 50%, | ||
#78dce8 100%); | ||
} | ||
--d3fc-full--gradient: linear-gradient( | ||
#ff6188 0%, | ||
#272822 50%, | ||
#78dce8 100% | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could use some help with testing this rule. I couldn't find anywhere where
dragging
is set on the viewer's classes, and various drag/drop operations I tried didn't seem to add the class name to the viewer either