Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/improve error messages #594

Merged
merged 6 commits into from
Aug 28, 2024

Conversation

matthewrfellows
Copy link
Contributor

A small first contribution that tweaks error messages in Morphir-Scala ErrorUtils.

Copy link

linux-foundation-easycla bot commented May 4, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@michelchan
Copy link
Contributor

Is this still wanted?

@edwardpeters
Copy link
Contributor

Is this still wanted?

It's a trivial but useful change - those messages tripped a few people up. 90% certain the test failures are an incremental issue, not a code problem, so if a rebuild is triggered I bet it would pass.

@michelchan
Copy link
Contributor

Is this still wanted?

It's a trivial but useful change - those messages tripped a few people up. 90% certain the test failures are an incremental issue, not a code problem, so if a rebuild is triggered I bet it would pass.

I'll update it and kick off a new build after getting some dependency upgrades merged in.

Copy link
Contributor

@michelchan michelchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@michelchan michelchan merged commit b8ad378 into finos:main Aug 28, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants