New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed mis-named function and added comments #577

Merged

DamianReeves merged 2 commits into finos:main from edwardpeters:rename-bad-functions-issue-575

Apr 11, 2024

Contributor

edwardpeters commented Apr 11, 2024

This PR addresses #575 by renaming some mis-named helper functions in MaybeSDK

edwardpeters added 2 commits

April 11, 2024 08:26


          Fixed mis-named function and added comments

8e87647


          Rebased to include new functions

9fe8d91

edwardpeters force-pushed the rename-bad-functions-issue-575 branch from 933eab2 to 9fe8d91 Compare

April 11, 2024 15:31

edwardpeters requested review from DamianReeves and sahilravinder

April 11, 2024 15:36

DamianReeves approved these changes

View reviewed changes

Member

DamianReeves left a comment

LGTM.
Will need to take a look at the entire SDK in another pass and make sure we use consistent naming.

DamianReeves merged commit b0caaa0 into finos:main

14 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet