Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elm format for tests #485

Merged
merged 4 commits into from
Dec 7, 2023
Merged

Conversation

justin-corn
Copy link
Contributor

This updates the morphir-elm version, runs elm-format on the existing test elm files, and recompiles morphir-ir.json for tests.

Copy link

netlify bot commented Dec 4, 2023

Deploy Preview for magical-donut-e8221d failed.

Name Link
🔨 Latest commit 3d07079
🔍 Latest deploy log https://app.netlify.com/sites/magical-donut-e8221d/deploys/656f5a66a160810008335f65

@justin-corn
Copy link
Contributor Author

❌ Deploy Preview for magical-donut-e8221d failed.

Name Link
🔨 Latest commit 1ebba6b
🔍 Latest deploy log https://app.netlify.com/sites/magical-donut-e8221d/deploys/656e39ffcef2e40008f93d9c

I'm now working on resolving this.

@justin-corn
Copy link
Contributor Author

I don't know how to resolve the current netlify build failure

https://app.netlify.com/sites/magical-donut-e8221d/deploys/656e3cb3b4e8790008af6972

12:44:08 PM: Installing npm packages using Yarn version 3.2.3
12:44:08 PM: ➤ YN0000: ┌ Resolution step
12:44:10 PM: Failed during stage "Install dependencies": dependency_installation script returned non-zero exit code: 1
12:44:10 PM: ➤ YN0002: │ @docsearch/react@npm:3.3.0 [45e70] doesn"t provide @algolia/client-search (p23f6c), requested by @algolia/autocomplete-preset-algolia
➤ YN0002: │ morphir-elm@npm:2.86.0 doesn"t provide @egjs/hammerjs (p68645), requested by vis-network
➤ YN0002: │ morphir-elm@npm:2.86.0 doesn"t provide component-emitter (p73baa), requested by vis-network
➤ YN0002: │ morphir-elm@npm:2.86.0 doesn"t provide keycharm (p33d27), requested by vis-network
➤ YN0002: │ morphir-elm@npm:2.86.0 doesn"t provide timsort (p1f5e7), requested by vis-network
➤ YN0002: │ morphir-elm@npm:2.86.0 doesn"t provide uuid (p63695), requested by vis-network
➤ YN0002: │ morphir-elm@npm:2.86.0 doesn"t provide vis-data (pe95d3), requested by vis-network
➤ YN0002: │ morphir-elm@npm:2.86.0 doesn"t provide vis-util (pff746), requested by vis-network
➤ YN0000: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code
12:44:10 PM: ➤ YN0000: └ Completed in 1s 670ms

Because of the first netlify error, which I couldn't figure out how to resolve on my COF laptop because of proxy, I reverted the change that updated the base package.json morphir-elm version, and made it so only the package.json within the examples/.../tests specifies the newer version. Now it looks like even that (the original version of morphir-elm) is failing.

Any idea what I should try next, @DamianReeves ?

@DamianReeves DamianReeves merged commit c645291 into finos:main Dec 7, 2023
14 of 17 checks passed
@DamianReeves
Copy link
Member

I've merged this and will look at the Netlify stuff later.
We are planning on moving the morphir-scala docs to the main morphir documentation site at https://morphir.finos.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants