Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Result.Tuple(Any) typed, better Dict.fromList, add Dict.toList #365

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

deusaquilus
Copy link
Contributor

@deusaquilus deusaquilus commented Aug 31, 2023

  • Make Result.Tuple(Any) argument typed similar to the way SDKNativeFunction was done.
  • Make Result.NativeFunction(Any) type similar to the way SDKNativeFunction was done
  • Needed a few helpers for the above things e.g. List => Tuple translation (that stuff exists in the standard library but only in Scala 3 and we're cross-compiling the evaluator)
  • Needed a few helpers to convert NativeFunctionSignature if it takes a store (i.e. something that can execute inside of a native function like List.map)
  • These things required various changes in EvaluatorQuick.scala and Loop.scala
  • Implemented Dict.toList and fixed up Dict.fromList. Added a test.

@netlify
Copy link

netlify bot commented Aug 31, 2023

Deploy Preview for magical-donut-e8221d ready!

Name Link
🔨 Latest commit 8ddbead
🔍 Latest deploy log https://app.netlify.com/sites/magical-donut-e8221d/deploys/64f009e817515400089b2462
😎 Deploy Preview https://deploy-preview-365--magical-donut-e8221d.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@DamianReeves DamianReeves merged commit d5f41a2 into finos:main Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants