Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Printing and fromString to QualifiedModuleName #343

Merged
merged 3 commits into from
Aug 22, 2023

Conversation

deusaquilus
Copy link
Contributor

@deusaquilus deusaquilus commented Aug 22, 2023

  • QualifiedModuleName needs a toString to print easily.
  • Also should have a fromString to parse easily.
  • In order to do that, need to add helpers similar to fqn. I called them qmn.
  • Also, it's easiest to reuse FQNaming options so I extracted that out into a separate module.

@netlify
Copy link

netlify bot commented Aug 22, 2023

Deploy Preview for magical-donut-e8221d ready!

Name Link
🔨 Latest commit b3ec041
🔍 Latest deploy log https://app.netlify.com/sites/magical-donut-e8221d/deploys/64e41ce7b9ea120008d12cc1
😎 Deploy Preview https://deploy-preview-343--magical-donut-e8221d.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@DamianReeves
Copy link
Member

Gonna merge this, but I feel some of this naming stuff is getting crazy, and I never was a huge fan of FQNamingOptions... This feels like a place where currying and partial application should be used.

You can easily go from a PackageName to a QualifiedModuleName and from a QualifiedModuleName to an FQName.

@DamianReeves DamianReeves merged commit fcf41af into finos:main Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants