-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
562 AppD vendor agnostic native apps #671
562 AppD vendor agnostic native apps #671
Conversation
… the standardized application types
@ggeorgievx here's an initial proposal for vendor-agnostic native app launch details and the tweaks I mentioned to the type/details/hostManifests relationship.
In particular, can you check the citrix launch args against what you use? To run the thing locally run the following in the website folder: then take a look at: http://localhost:3000/schemas/next/app-directory#tag/Application/paths/~1v2~1apps/post |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kriswest LGTM! Thank you for clarifying the relationship between hostManifests
and details
!
Two minor things:
- should we add a comment about DAs that don't support certain types of applications?
- should we leave the host application type to allow for other application types?
Good idea. We could either:
I'm leaning towards the latter as interop between web and other apps types is what I think most would expect of a 'FDC3 compliant' desktop agent and I know of no implementations that don't support web apps...
A good point - although I might prefer and |
I agree with you.
Happy to rename As both changes would require minimal changes I suggest we raise this at the next AppD WG. |
… MAY be supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only outstanding question is whether path & arguments is enough for native apps (and url for online native) or whether we need to support some sort of appAsset and alias combo.
From our side path
+ arguments
is sufficient. Thank you @kriswest!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only outstanding question is whether path & arguments is enough for native apps (and url for online native) or whether we need to support some sort of appAsset and alias combo.
From our side path
+ arguments
is sufficient. Thank you @kriswest!
resolves #562
Introduces launch details for native application types and adjusts the standardized application types to accommodate. Also adjusts the relationship between
type
,details
andhostManifests
by eliminating thehost
application type and allowinghostManifests
to overridedetails
if they want/need to. I believe this makes the (vendor agnostic)details
field more useful and more likely to be used than if it is simply ommited when a hostManifest is used. This allowsdetails
to become a required field.Documentation example:EDIT: see updated example in comment thread instead
Change was agreed in principle (but not in detail) at meeting: