-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
518 Added error UserCancelled to the ResolveError enumeration #522
Merged
kriswest
merged 5 commits into
finos:master
from
InteropIO:518-Add-option-to-ResolveError-for-user-cancelled
Feb 4, 2022
Merged
518 Added error UserCancelled to the ResolveError enumeration #522
kriswest
merged 5 commits into
finos:master
from
InteropIO:518-Add-option-to-ResolveError-for-user-cancelled
Feb 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when user closes the resolver UI or otherwise cancels resolution of a raised intent
kriswest
requested review from
mattjamieson,
rikoe,
donbasuno,
ggeorgievx and
a team
December 3, 2021 13:45
Looks good to me. Thanks Kris. |
kriswest
added
the
channels feeds & transactions
Channels, Feeds & Transactions Discussion Group
label
Dec 14, 2021
mattjamieson
approved these changes
Dec 21, 2021
rikoe
approved these changes
Dec 21, 2021
hughtroeger
approved these changes
Jan 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment about the changelog, otherwise looks good.
ggeorgievx
approved these changes
Jan 27, 2022
Co-authored-by: Hugh Troeger <troeger.hugh@gmail.com>
kriswest
commented
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api
FDC3 API Working Group
channels feeds & transactions
Channels, Feeds & Transactions Discussion Group
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #518
Added error
UserCancelled
to theResolveError
enumeration to be used when the user closes the resolver UI or otherwise cancels resolution of a raised intent.