Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

518 Added error UserCancelled to the ResolveError enumeration #522

Conversation

kriswest
Copy link
Contributor

@kriswest kriswest commented Dec 3, 2021

resolves #518

Added error UserCancelled to the ResolveError enumeration to be used when the user closes the resolver UI or otherwise cancels resolution of a raised intent.

…when user closes the resolver UI or otherwise cancels resolution of a raised intent
@kriswest kriswest added enhancement New feature or request api FDC3 API Working Group labels Dec 3, 2021
@hampshan
Copy link

hampshan commented Dec 3, 2021

Looks good to me. Thanks Kris.

@kriswest kriswest added the channels feeds & transactions Channels, Feeds & Transactions Discussion Group label Dec 14, 2021
Copy link
Contributor

@hughtroeger hughtroeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment about the changelog, otherwise looks good.

CHANGELOG.md Outdated Show resolved Hide resolved
docs/api/ref/DesktopAgent.md Outdated Show resolved Hide resolved
Co-authored-by: Hugh Troeger <troeger.hugh@gmail.com>
@kriswest kriswest merged commit 924855e into finos:master Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api FDC3 API Working Group channels feeds & transactions Channels, Feeds & Transactions Discussion Group enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing ResolveError option when a user cancels raiseIntent
6 participants