Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update position.schema.json #419

Merged

Conversation

dominicgifford
Copy link
Contributor

Removed the requirement to have a minimum holding of 0 as this does not support short positions.

To resolve issue #391

Removed the requirement to have a minimum holding of 0 as this does not support short positions
@finos-cla-bot
Copy link

finos-cla-bot bot commented Jul 12, 2021

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement.

Having reviewed our contributor list, we require a CLA for the following people : (@dominicgifford).

If you need help obtaining a CLA, please read the Requirements for Contributions section of our CLA wiki or email help@finos.org with your questions.

Thanks once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request.

cc @finos-admin

@kriswest
Copy link
Contributor

@dominicgifford could you take a look at https://finosfoundation.atlassian.net/wiki/spaces/FINOS/pages/75530375/Legal+Requirements#LegalRequirements-ContributorLicenseAgreement
and get your CLA registered. We should be able to complete review and merge this thereafter.

@dominicgifford
Copy link
Contributor Author

@dominicgifford could you take a look at https://finosfoundation.atlassian.net/wiki/spaces/FINOS/pages/75530375/Legal+Requirements#LegalRequirements-ContributorLicenseAgreement
and get your CLA registered. We should be able to complete review and merge this thereafter.

I emailed help@finos.org on 12/07 asking if my org already had a CCLA.
No response as yet. Who can confirm?

@rikoe
Copy link
Contributor

rikoe commented Jul 22, 2021

@maoo @mcleo-d can you please help @dominicgifford out in terms of CLA?

@mcleo-d
Copy link
Member

mcleo-d commented Jul 28, 2021

Hi @dominicgifford

Thanks for your comment above. I am taking this forward inside FINOS and will reply to you via email with further updates.

Apologies for the delay in getting back to you.

James.

@mcleo-d
Copy link
Member

mcleo-d commented Aug 4, 2021

Hi @dominicgifford 👋🏻

I'm pleased to confirm you have now been added to the IHS Markit CCLA and can make a minor change to this PR to see if the CLABot succeeds as done here - finos/open-developer-platform#226 (comment)

@kriswest and @rikoe - This PR is ready to be reviewed and merged when ready. Let me know if more help is needed 👍🏻

Thank you and great work!

James 🚀

added line break to trigger re-evaluation of CCLA on Pull Request
Copy link
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kriswest
Copy link
Contributor

kriswest commented Aug 4, 2021

I'm pleased to confirm you have now been added to the IHS Markit CCLA and can make a minor change to this PR to see if the CLABot succeeds as done here - finos/open-developer-platform#226 (comment)

No need for a change, I was able to approve and re-run the CLA workflow on it

@kriswest kriswest merged commit 2257063 into finos:master Aug 4, 2021
@mcleo-d
Copy link
Member

mcleo-d commented Aug 4, 2021

👏🏻 💯 💯 💯 - Thanks all for working this through 👍🏻

@dominicgifford
Copy link
Contributor Author

yes, thanks to everyone :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why only positive holdings in a position context?
4 participants