Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support raise Intent without a context #375

Merged
merged 5 commits into from
Oct 7, 2021
Merged

Support raise Intent without a context #375

merged 5 commits into from
Oct 7, 2021

Conversation

kriswest
Copy link
Contributor

@kriswest kriswest commented Apr 27, 2021 •
edited
Loading

resolves #361 …by adding an explicit Null context type

N.B. I couldn't run yarn typegen as the schema is not yet deployed to the web.

N.B. 2 I got some weird output from git on this commit @rikoe
image

@kriswest
resolves finos#361 (support raise Intent without a context) by adding…
609a9d7 
… an explicit Null context type

N.B. I couldn't run yarn run v1.22.10
$ cd src/context && quicktype -s schema --src-urls schemas.json -o ContextTypes.ts
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. as the schema is not yet deployed to the web.
@kriswest kriswest requested a review from rikoe April 27, 2021 13:09
@kriswest kriswest mentioned this pull request Apr 27, 2021
Closed
@rikoe
Copy link
Contributor

rikoe commented Jun 24, 2021

I would still prefer the context type used for this to be fdc3.nothing instead of fdc3.null - can we discuss this in an upcoming meeting @kriswest?

Reason being that null is a technical term, while the context types are more business-oriented. And I believe it makes the intention clearer.

@mattjamieson @ggeorgievx @donbasuno any thoughts?

@kriswest kriswest mentioned this pull request Jul 22, 2021
Closed
@kriswest kriswest linked an issue Aug 4, 2021 that may be closed by this pull request
Support raiseIntent without a context #361
Closed
@kriswest kriswest mentioned this pull request Sep 7, 2021
Closed
21 tasks
@kriswest
Copy link
Contributor Author

fdc3.null changed fdc3.nothing throughout - this should now be ready to merge (post-review)

@kriswest kriswest added this to the 2.0 milestone Sep 14, 2021
@kriswest kriswest mentioned this pull request Sep 22, 2021
Closed
14 tasks
@kriswest kriswest mentioned this pull request Sep 30, 2021
Closed
14 tasks
@kriswest kriswest changed the title resolves #361 (support raise Intent without a context) Support raise Intent without a context Sep 30, 2021
@rikoe rikoe merged commit 5930503 into finos:master Oct 7, 2021
@kriswest kriswest deleted the #361-raiseIntent-without-a-context branch October 8, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikoe rikoe rikoe approved these changes

@mattjamieson mattjamieson mattjamieson approved these changes

@donbasuno donbasuno Awaiting requested review from donbasuno

@ggeorgievx ggeorgievx Awaiting requested review from ggeorgievx

Assignees
No one assigned
Labels
cla-present
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

Support raiseIntent without a context
3 participants
@kriswest @rikoe @mattjamieson