Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a new Target type, updates open() and raiseIntent() #279

Merged
merged 9 commits into from
Dec 3, 2020
Merged

Adds a new Target type, updates open() and raiseIntent() #279

merged 9 commits into from
Dec 3, 2020

Conversation

sean-ciq
Copy link
Contributor

@sean-ciq sean-ciq commented Nov 11, 2020 •
edited
Loading

This PR adds a new Target type definition to src/api. It also adjusts the target argument currently in open() and raiseIntent() to accept that new type.

Changes include:

  1. Adding TargetType.ts to src/api
  2. open() and raiseIntent() now accept target: Target instead of target: string | AppMetadata
  3. Changes IntentResolution.souce to use Target type

@sean-ciq sean-ciq mentioned this pull request Nov 11, 2020
Merged
@sean-ciq
Copy link
Contributor Author

Should be merged after #272

@mattjamieson mattjamieson mentioned this pull request Dec 2, 2020
Closed
@rikoe rikoe merged commit 2b187b8 into finos:master Dec 3, 2020
@rikoe rikoe added this to the 1.2 milestone Jan 26, 2021
@kriswest kriswest deleted the feature/add-target-type branch October 8, 2021 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikoe rikoe rikoe approved these changes

Assignees
No one assigned
Labels
cla-present
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@sean-ciq @rikoe