-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impl fix build #1405
Impl fix build #1405
Conversation
The CVE Scanning was failing due to this bug in auditjs: sonatype-nexus-community/auditjs#278 |
Now the initial API types have had schemas created, it is unlikely that we'll auto-generate them again.
…to impl-fix-build
…to impl-fix-build
Note - I'm marking all of the failing gherkin tests as I want to skip the failing tests so that we can see if there are other issues in the test system. Once we iron out all the other kinks, I'm going to go back and try to fix up the failing tests. Since they've been tagged, we can easily identify which tests were skipped. |
The GHA tool that was used to generate the report hasn't been updated in over a year, and only supports Node v16.x. We use Node versions 18.x and 20.x. I would recommend against using this tool. I am investigating alternatives for comment-based code coverage reporting. Meanwhile, we now have all green checkmarks. |
npm run build
fails onfdc3-for-web-impl
I can't push to that branch directly, so I'm chipping away at the errors in this PR.
fyi @robmoffat @kriswest