Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated for 2.2 Conformance #1272

Draft
wants to merge 4 commits into
base: fdc3-for-web
Choose a base branch
from
Draft

Conversation

robmoffat
Copy link
Member

No description provided.

@robmoffat robmoffat marked this pull request as draft July 18, 2024 10:56
@robmoffat
Copy link
Member Author

@kriswest anything else to add to this? Perhaps something around the channel change listener?

@kriswest
Copy link
Contributor

kriswest commented Aug 1, 2024

@kriswest anything else to add to this? Perhaps something around the channel change listener?

I can confidently say yes theres more to add - but I'm not focused on it right now. This is secondary to getting the scope for 2.2 agreed. The maintainers can deal with confirmance after whats going in is settled. Hence, I'll keep focused on FDC3 for the web and other proposals out there for the time being.

Definitely, needs addEventLisatener checks. We need to decide on other proposals like matching private channel event listeners to that (I think it would be a good idea to get it done at the same time!). I think you might also check for a case that covers the receiving context on join/addContextListener (as we discussed earlier today) and make sure it covers cases with overlapping context listeners (two of same type or a type + null). The behaviour of the API is well-defined on that and as dsicussed it might be easy to get that wrong with FDC3 for the web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants