Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StepSecurity] ci: Harden GitHub Actions (Pinned Dependencies) #1247

Merged

Conversation

step-security-bot
Copy link
Contributor

Summary

This pull request is created by StepSecurity at the request of @bingenito. Please merge the Pull Request to incorporate the requested changes. Please tag @bingenito on your message if you have any questions related to the PR.
Fixes #1245

Security Fixes

Pinned Dependencies

GitHub Action tags and Docker tags are mutable. This poses a security risk. GitHub's Security Hardening guide recommends pinning actions to full length commit.

Feedback

For bug reports, feature requests, and general feedback; please email support@stepsecurity.io. To create such PRs, please visit https://app.stepsecurity.io/securerepo.

Signed-off-by: StepSecurity Bot bot@stepsecurity.io

Signed-off-by: StepSecurity Bot <bot@stepsecurity.io>
Copy link

linux-foundation-easycla bot commented Jul 3, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: step-security-bot / name: StepSecurity Bot (6d77505)
  • ✅ login: bingenito / name: Brian Ingenito (70de1c4, 788dec9)

Copy link

netlify bot commented Jul 3, 2024

Deploy Preview for fdc3 canceled.

Name Link
🔨 Latest commit 70de1c4
🔍 Latest deploy log https://app.netlify.com/sites/fdc3/deploys/668c161d7c96a80008c47c21

@bingenito bingenito requested a review from a team July 3, 2024 10:41
@bingenito bingenito changed the title [StepSecurity] ci: Harden GitHub Actions [StepSecurity] ci: Harden GitHub Actions (Pinned Dependencies) Jul 3, 2024
Copy link
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - although you could try bumping those deps to the current releases in the CVE-scanning and semgrep workflows

.github/workflows/cve-scanning.yml Outdated Show resolved Hide resolved
.github/workflows/cve-scanning.yml Outdated Show resolved Hide resolved
.github/workflows/semgrep.yml Outdated Show resolved Hide resolved
@kriswest
Copy link
Contributor

kriswest commented Jul 4, 2024

@maoo @robmoffat do we need to get step-security added to easy CLA (some sort of exception)? Or are we ok to just merge its changes after review?

@bingenito will we no longer be able to merge without the easycla check passing if we implement all the governance / github settings changes proposed?

@maoo
Copy link
Member

maoo commented Jul 4, 2024

@maoo @robmoffat do we need to get step-security added to easy CLA (some sort of exception)? Or are we ok to just merge its changes after review?

If the PR is time-sensitive, go ahead and merge (or ask help@finos.org to force the merge, if you're not able to).

I've created a ticket to the EasyCLA team to add step-security-bot as a bot (and if there's a way for us to do it on our own).

Make sure to keep @TheJuanAndOnly99 in the loop (also for similar issues in the future), as I'll be off until the 16th of July.

Thank you!

@kriswest
Copy link
Contributor

kriswest commented Jul 4, 2024

We may change the set up to require checks to pass before merging is allowed so this might become an issue in future - hence, great if you are getting the bot setup. For now we can move ahead - although I'll defer to @bingenito on when to merge this ;-) .

@bingenito
Copy link
Member

will we no longer be able to merge without the easycla check passing if we implement all the governance / github settings changes proposed?

Only if we add easycla as one of the required status checks (which arguably we should)

@finos finos locked and limited conversation to collaborators Jul 4, 2024
@maoo
Copy link
Member

maoo commented Jul 4, 2024

/easycla

1 similar comment
@kriswest
Copy link
Contributor

kriswest commented Jul 5, 2024

/easycla

@finos finos unlocked this conversation Jul 5, 2024
@kriswest
Copy link
Contributor

kriswest commented Jul 5, 2024

/easycla

@kriswest
Copy link
Contributor

kriswest commented Jul 5, 2024

@bingenito @maoo apparently locking the conversation blocks EasyCLA updating its comments! The Step-security now passes the easycla check

@bingenito
Copy link
Member

@kriswest I updated versions to match across actions

@kriswest
Copy link
Contributor

kriswest commented Jul 8, 2024

@bingenito great! I'm closing and reopening this PR as it should trigger 2 of the 3 workflows on reopen (we can test the package workflow on releasing the NPM module once I have a necessary review for a/the 2.1.1 release).

@kriswest kriswest closed this Jul 8, 2024
@kriswest kriswest reopened this Jul 8, 2024
Copy link
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is well! It did actually run the package workflow as well. LGTM

@kriswest kriswest merged commit fdf060f into finos:main Jul 8, 2024
12 checks passed
@bingenito
Copy link
Member

@TheJuanAndOnly99 You ok with this from a security stance?

@TheJuanAndOnly99
Copy link
Member

@bingenito Yes definitely! This tool is very interesting. I think it could be useful to others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update actions to pin dependencies
5 participants