-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[StepSecurity] ci: Harden GitHub Actions (Pinned Dependencies) #1247
[StepSecurity] ci: Harden GitHub Actions (Pinned Dependencies) #1247
Conversation
Signed-off-by: StepSecurity Bot <bot@stepsecurity.io>
✅ Deploy Preview for fdc3 canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - although you could try bumping those deps to the current releases in the CVE-scanning and semgrep workflows
@maoo @robmoffat do we need to get step-security added to easy CLA (some sort of exception)? Or are we ok to just merge its changes after review? @bingenito will we no longer be able to merge without the easycla check passing if we implement all the governance / github settings changes proposed? |
If the PR is time-sensitive, go ahead and merge (or ask help@finos.org to force the merge, if you're not able to). I've created a ticket to the EasyCLA team to add Make sure to keep @TheJuanAndOnly99 in the loop (also for similar issues in the future), as I'll be off until the 16th of July. Thank you! |
We may change the set up to require checks to pass before merging is allowed so this might become an issue in future - hence, great if you are getting the bot setup. For now we can move ahead - although I'll defer to @bingenito on when to merge this ;-) . |
Only if we add easycla as one of the required status checks (which arguably we should) |
/easycla |
1 similar comment
/easycla |
/easycla |
@bingenito @maoo apparently locking the conversation blocks EasyCLA updating its comments! The Step-security now passes the easycla check |
@kriswest I updated versions to match across actions |
@bingenito great! I'm closing and reopening this PR as it should trigger 2 of the 3 workflows on reopen (we can test the package workflow on releasing the NPM module once I have a necessary review for a/the 2.1.1 release). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All is well! It did actually run the package workflow as well. LGTM
@TheJuanAndOnly99 You ok with this from a security stance? |
@bingenito Yes definitely! This tool is very interesting. I think it could be useful to others. |
Summary
This pull request is created by StepSecurity at the request of @bingenito. Please merge the Pull Request to incorporate the requested changes. Please tag @bingenito on your message if you have any questions related to the PR.
Fixes #1245
Security Fixes
Pinned Dependencies
GitHub Action tags and Docker tags are mutable. This poses a security risk. GitHub's Security Hardening guide recommends pinning actions to full length commit.
Feedback
For bug reports, feature requests, and general feedback; please email support@stepsecurity.io. To create such PRs, please visit https://app.stepsecurity.io/securerepo.
Signed-off-by: StepSecurity Bot bot@stepsecurity.io