Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openssf scorecard action and readme badge displaying score #1188

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

bingenito
Copy link
Member

@bingenito bingenito commented Apr 12, 2024

Run openssf scorecard action weekly and on pushes to main branch (will create code scan analysis security entries if required).


THIS SOFTWARE IS CONTRIBUTED SUBJECT TO THE TERMS OF THE FINOS CORPORATE CONTRIBUTOR LICENSE AGREEMENT.

THIS SOFTWARE IS LICENSED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE AND ANY WARRANTY OF NON-INFRINGEMENT, ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. THIS SOFTWARE MAY BE REDISTRIBUTED TO OTHERS ONLY BY EFFECTIVELY USING THIS OR ANOTHER EQUIVALENT DISCLAIMER IN ADDITION TO ANY OTHER REQUIRED LICENSE TERMS.

@bingenito bingenito requested review from robmoffat and a team April 12, 2024 14:28
Copy link

netlify bot commented Apr 12, 2024

Deploy Preview for fdc3 ready!

Name Link
🔨 Latest commit cae39a4
🔍 Latest deploy log https://app.netlify.com/sites/fdc3/deploys/663b90c3a876460009a5a125
😎 Deploy Preview https://deploy-preview-1188--fdc3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

# - you want to enable the Branch-Protection check on a *public* repository, or
# - you are installing Scorecard on a *private* repository
# To create the PAT, follow the steps in https://github.com/ossf/scorecard-action?tab=readme-ov-file#authentication-with-fine-grained-pat-optional.
repo_token: ${{ secrets.SCORECARD_TOKEN }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is defined at the org level as evidenced by the scorecard action working in other FINOS projects.

README.md Outdated Show resolved Hide resolved
# For private repositories:
# - `publish_results` will always be set to `false`, regardless
# of the value entered here.
publish_results: false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non public publish. This will keep results as local code scanning issues.

@bingenito
Copy link
Member Author

@kriswest When/If we merge this one can we do a squash merge? I was having issues rebasing locally to squash and reword the commit.

@kriswest
Copy link
Contributor

@kriswest When/If we merge this one can we do a squash merge? I was having issues rebasing locally to squash and reword the commit.

@bingenito I don't see why not (as long as we remember).

@robmoffat I think this one is with you to review - along with another action related to the badge

Copy link
Member

@robmoffat robmoffat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just need a token now, right?

@bingenito
Copy link
Member Author

Token seems to be present at org level because scorecard is working for other projects such as fdc3-dotnet. Will find out once I merge.

@bingenito bingenito merged commit 4b4b3e4 into finos:main Jun 6, 2024
9 checks passed
Copy link
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants