Skip to content

Commit

Permalink
Merge pull request #1386 from Roaders/window-fdc3-optional
Browse files Browse the repository at this point in the history
Make window.fdc3 optional
  • Loading branch information
kriswest authored Oct 21, 2024
2 parents 1a21b02 + cb40194 commit 001b6cc
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

### Changed

* `window.fdc3` is now an optional property and may or may not be defined. Applications should now use `getAgent()` as the recommended way of retrieving a reference to the FDC3 API. ([#1386](https://github.com/finos/FDC3/pull/1386))
* `Listener.unsubscribe()` was made async (the return type was changed from `void` to `Promise<void>`) for consistency with the rest of the API. ([#1305](https://github.com/finos/FDC3/pull/1305))
* Added reference materials and supported platforms information for FDC3 in .NET via the [finos/fdc3-dotnet](https://github.com/finos/fdc3-dotnet) project. ([#1108](https://github.com/finos/FDC3/pull/1108))
* The supported platforms page in the FDC3 documentation was moved into the API section as the information it provides all relates to FDC3 Desktop Agent API implementations. ([#1108](https://github.com/finos/FDC3/pull/1108))
Expand Down
1 change: 0 additions & 1 deletion src/api/DesktopAgent.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import { ImplementationMetadata } from './ImplementationMetadata';
import { PrivateChannel } from './PrivateChannel';
import { AppIdentifier } from './AppIdentifier';
import { AppMetadata } from './AppMetadata';
import { DesktopAgentDetails } from './GetAgent';
import { Intent } from '../intents/Intents';
import { ContextType } from '../context/ContextType';
import { EventHandler, FDC3EventTypes } from './Events';
Expand Down
3 changes: 2 additions & 1 deletion src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ export * from './api/ContextMetadata';
export * from './api/DesktopAgent';
export * from './api/DisplayMetadata';
export * from './api/Errors';
export * from './api/GetAgent';
export * from './api/Icon';
export * from './api/Image';
export * from './api/ImplementationMetadata';
Expand All @@ -42,6 +43,6 @@ export { BrowserTypes };

declare global {
interface Window {
fdc3: DesktopAgent;
fdc3?: DesktopAgent;
}
}

0 comments on commit 001b6cc

Please sign in to comment.