forked from gap-system/gap
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Change GroupWithGenerators to accept collections again
In GAP <= 4.9, this worked: gap> GroupWithGenerators( Group( (1,2) ) ); Group([ (), (1,2) ]) In GAP 4.10, this was broken and instead lead to a "method not found" error. While strictly speaking this was never documented behavior, we restore it to avoid regressions in code that relied on this undocumented behavior. Resolves gap-system#2703
- Loading branch information
Showing
2 changed files
with
9 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
# These are undocumented, but should still work | ||
gap> GroupByGenerators( Group( (1,2) ) ); | ||
Group([ (), (1,2) ]) | ||
gap> GroupWithGenerators( Group( (1,2) ) ); | ||
Group([ (), (1,2) ]) |