Apply suggestions from code review

Co-authored-by: Max Horn <max@quendi.de>
fingolfin · Jan 30, 2024 · ac9afc0 · ac9afc0
1 parent c8d7b0e
commit ac9afc0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/dev/releases/make_archives.py b/dev/releases/make_archives.py
@@ -121,9 +121,8 @@
 manifest_list = []  # collect names of assets to be uploaded to GitHub release
 
 # download package distribution
-notice(
-    "Downloading package distribution"
-)  # ... outside of the directory we just created
+# outside of the directory we just created
+notice("Downloading package distribution")
 download_with_sha256(
     PKG_BOOTSTRAP_URL + "package-infos.json.gz", tmpdir + "/" + "package-infos.json.gz"
 )
@@ -271,7 +270,7 @@ def make_and_record_archive(name, compression, root_dir, base_dir):
     else:
         error(f"unknown compression type {compression} (not gztar or zip)")
 
-    fname = f"{name}{ext}"
+    fname = name + ext
     notice(f"Creating {fname}")
     owner = pwd.getpwuid(0).pw_name
     group = grp.getgrgid(0).gr_name

diff --git a/dev/releases/update_website.py b/dev/releases/update_website.py
@@ -81,7 +81,7 @@ def download_asset_by_name(asset_name, writedir):
         utils.download_with_sha256(url, asset_name)
 
 
-def extract_tball(tball):
+def extract_tarball(tarball):
     notice(f"Extracting {tball} . . .")
     with tarfile.open(tball) as tar:
         try: