Fix infinite recursion in ReplacedString

... when <old> is empty
fingolfin · Oct 22, 2023 · 70bca27 · 70bca27
1 parent 58d9d53
commit 70bca27
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/lib/init.g b/lib/init.g
@@ -104,7 +104,13 @@ infinity := "2b defined";
 ##
 ReplacedString := function ( str, old, new, arg... )
     local lss, all, p, s, pp;
+    if old = new then
+        return str;
+    fi;
     lss := LEN_LIST( old );
+    if lss = 0  then
+        Error("<old> must not be empty");
+    fi;
     if LEN_LIST( arg ) > 0  then
         all := arg[1] = "all";
     else

diff --git a/tst/testinstall/strings.tst b/tst/testinstall/strings.tst
@@ -209,5 +209,13 @@ gap> for len in [10,100,1000,10000,100000] do
 > Assert(0, Concatenation(str,"\n") = DisplayString(str));
 > od;;
 
+#
+gap> ReplacedString("Hello world", "Hello", "Goodbye");
+"Goodbye world"
+gap> ReplacedString("Hello world", "", "");
+"Hello world"
+gap> ReplacedString("Hello world", "", "*");
+Error, <old> must not be empty
+
 #
 gap> STOP_TEST( "strings.tst", 1);