Skip to content

Commit

Permalink
Change GroupByGenerators to accept collections again
Browse files Browse the repository at this point in the history
In GAP <= 4.9, this worked:

    gap> GroupByGenerators( Group( (1,2) ) );
    Group([ (), (1,2) ])

In GAP 4.10, this was broken and instead lead to a "method not found" error.
While strictly speaking this was never documented behavior, we restore it
to avoid regressions in code that relied on this undocumented behavior.

Resolves gap-system#2703
  • Loading branch information
fingolfin committed Dec 6, 2018
1 parent 8a9aa64 commit 4015cf7
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions lib/grp.gi
Original file line number Diff line number Diff line change
Expand Up @@ -4401,6 +4401,7 @@ InstallMethod( GroupWithGenerators,
function( gens )
local G,typ;

gens:=AsList(gens);
typ:=MakeGroupyType(FamilyObj(gens),
IsGroup and IsAttributeStoringRep
and HasIsEmpty and HasGeneratorsOfMagmaWithInverses,
Expand All @@ -4418,6 +4419,7 @@ InstallMethod( GroupWithGenerators,
function( gens, id )
local G,typ;

gens:=AsList(gens);
typ:=MakeGroupyType(FamilyObj(gens),
IsGroup and IsAttributeStoringRep
and HasIsEmpty and HasGeneratorsOfMagmaWithInverses and HasOne,
Expand Down

0 comments on commit 4015cf7

Please sign in to comment.