bcel updates #103
Comments
|
hmm, here is the diff, from the official bcel repo svn diff -r 1745834:1741710 dev/bcel/src/main/java/org/apache/commons/bcel6 |
|
Hi @mebigfatguy, maybe we can try syntax highlighting, here is my result of Index: src/main/java/org/apache/commons/bcel6/Constants.java
===================================================================
--- src/main/java/org/apache/commons/bcel6/Constants.java (revision 1745834)
+++ src/main/java/org/apache/commons/bcel6/Constants.java (revision 1741710)
@@ -1037,10 +1037,6 @@
/** Java VM opcode.
* @see <a href="http://docs.oracle.com/javase/specs/jvms/se8/html/jvms-6.html#jvms-6.5">
* Opcode definitions in The Java Virtual Machine Specification</a> */
- public static final short INVOKEDYNAMIC = 186;
- /** Java VM opcode.
- * @see <a href="http://docs.oracle.com/javase/specs/jvms/se8/html/jvms-6.html#jvms-6.5">
- * Opcode definitions in The Java Virtual Machine Specification</a> */
public static final short NEW = 187;
/** Java VM opcode.
* @see <a href="http://docs.oracle.com/javase/specs/jvms/se8/html/jvms-6.html#jvms-6.5">
@@ -1391,7 +1387,7 @@
0/*dreturn*/, 0/*areturn*/, 0/*return*/,
2/*getstatic*/, 2/*putstatic*/, 2/*getfield*/,
2/*putfield*/, 2/*invokevirtual*/, 2/*invokespecial*/, 2/*invokestatic*/,
- 4/*invokeinterface*/, 4/*invokedynamic*/, 2/*new*/,
+ 4/*invokeinterface*/, UNDEFINED, 2/*new*/,
1/*newarray*/, 2/*anewarray*/,
0/*arraylength*/, 0/*athrow*/, 2/*checkcast*/,
2/*instanceof*/, 0/*monitorenter*/,
@@ -1464,7 +1460,7 @@
{T_SHORT}/*putstatic*/, {T_SHORT}/*getfield*/,
{T_SHORT}/*putfield*/, {T_SHORT}/*invokevirtual*/,
{T_SHORT}/*invokespecial*/, {T_SHORT}/*invokestatic*/,
- {T_SHORT, T_BYTE, T_BYTE}/*invokeinterface*/, {T_SHORT, T_BYTE, T_BYTE}/*invokedynamic*/,
+ {T_SHORT, T_BYTE, T_BYTE}/*invokeinterface*/, {},
{T_SHORT}/*new*/, {T_BYTE}/*newarray*/,
{T_SHORT}/*anewarray*/, {}/*arraylength*/, {}/*athrow*/,
{T_SHORT}/*checkcast*/, {T_SHORT}/*instanceof*/,
@@ -1511,7 +1507,7 @@
"tableswitch", "lookupswitch", "ireturn", "lreturn", "freturn",
"dreturn", "areturn", "return", "getstatic", "putstatic", "getfield",
"putfield", "invokevirtual", "invokespecial", "invokestatic",
- "invokeinterface", "invokedynamic", "new", "newarray", "anewarray",
+ "invokeinterface", ILLEGAL_OPCODE, "new", "newarray", "anewarray",
"arraylength", "athrow", "checkcast", "instanceof", "monitorenter",
"monitorexit", "wide", "multianewarray", "ifnull", "ifnonnull",
"goto_w", "jsr_w", "breakpoint", ILLEGAL_OPCODE, ILLEGAL_OPCODE,
@@ -1567,7 +1563,7 @@
UNPREDICTABLE/*putstatic*/, 1/*getfield*/, UNPREDICTABLE/*putfield*/,
UNPREDICTABLE/*invokevirtual*/, UNPREDICTABLE/*invokespecial*/,
UNPREDICTABLE/*invokestatic*/,
- UNPREDICTABLE/*invokeinterface*/, UNPREDICTABLE/*invokedynamic*/, 0/*new*/, 1/*newarray*/, 1/*anewarray*/,
+ UNPREDICTABLE/*invokeinterface*/, UNDEFINED, 0/*new*/, 1/*newarray*/, 1/*anewarray*/,
1/*arraylength*/, 1/*athrow*/, 1/*checkcast*/, 1/*instanceof*/, 1/*monitorenter*/,
1/*monitorexit*/, 0/*wide*/, UNPREDICTABLE/*multianewarray*/, 1/*ifnull*/, 1/*ifnonnull*/,
0/*goto_w*/, 0/*jsr_w*/, 0/*breakpoint*/, UNDEFINED, UNDEFINED,
@@ -1623,7 +1619,7 @@
0/*dreturn*/, 0/*areturn*/, 0/*return*/, UNPREDICTABLE/*getstatic*/, 0/*putstatic*/,
UNPREDICTABLE/*getfield*/, 0/*putfield*/, UNPREDICTABLE/*invokevirtual*/,
UNPREDICTABLE/*invokespecial*/, UNPREDICTABLE/*invokestatic*/,
- UNPREDICTABLE/*invokeinterface*/, UNPREDICTABLE/*invokedynamic*/, 1/*new*/, 1/*newarray*/, 1/*anewarray*/,
+ UNPREDICTABLE/*invokeinterface*/, UNDEFINED, 1/*new*/, 1/*newarray*/, 1/*anewarray*/,
1/*arraylength*/, 1/*athrow*/, 1/*checkcast*/, 1/*instanceof*/, 0/*monitorenter*/,
0/*monitorexit*/, 0/*wide*/, 1/*multianewarray*/, 0/*ifnull*/, 0/*ifnonnull*/,
0/*goto_w*/, 1/*jsr_w*/, 0/*breakpoint*/, UNDEFINED, UNDEFINED, |
|
thanks |
|
@ALL: any idea what changed in 53 class version except the new version number? The current bcel snapshot from findbugs git repo seem to work fine with Java 9 generated classes. BTW, any idea how this snapshot was created and from which commit? P.S. |
|
More information here: |
|
I'll happily push any changes to bcel proper. One issue is that Apache On 06/05/2016 06:31 AM, Andrey Loskutov wrote:
|
|
Now that we are using BCEL trunk I think we can close this one as fixed. Feel free to reopen if there is something missing. |
I'm not sure where the custom bcel code is for findbugs anymore, but you may want to check your version of Constants.java for these changes... i think they are not included
Index: dev/bcel/src/main/java/org/apache/commons/bcel6/Constants.java
--- dev/bcel/src/main/java/org/apache/commons/bcel6/Constants.java (revision 1745834)
+++ dev/bcel/src/main/java/org/apache/commons/bcel6/Constants.java (revision 1741710)
@@ -1037,10 +1037,6 @@
/** Java VM opcode.
* @see
* Opcode definitions in The Java Virtual Machine Specification */
public static final short NEW = 187;
/* Java VM opcode.
@@ -1391,7 +1387,7 @@
0/dreturn/, 0/areturn/, 0/return/,
2/getstatic/, 2/putstatic/, 2/getfield/,
2/putfield/, 2/invokevirtual/, 2/invokespecial/, 2/invokestatic/,
1/newarray/, 2/anewarray/,
0/arraylength/, 0/athrow/, 2/checkcast/,
2/instanceof/, 0/monitorenter/,
@@ -1464,7 +1460,7 @@
{T_SHORT}/putstatic/, {T_SHORT}/getfield/,
{T_SHORT}/putfield/, {T_SHORT}/invokevirtual/,
{T_SHORT}/invokespecial/, {T_SHORT}/invokestatic/,
{T_SHORT}/new/, {T_BYTE}/newarray/,
{T_SHORT}/anewarray/, {}/arraylength/, {}/athrow/,
{T_SHORT}/checkcast/, {T_SHORT}/instanceof/,
@@ -1511,7 +1507,7 @@
"tableswitch", "lookupswitch", "ireturn", "lreturn", "freturn",
"dreturn", "areturn", "return", "getstatic", "putstatic", "getfield",
"putfield", "invokevirtual", "invokespecial", "invokestatic",
"arraylength", "athrow", "checkcast", "instanceof", "monitorenter",
"monitorexit", "wide", "multianewarray", "ifnull", "ifnonnull",
"goto_w", "jsr_w", "breakpoint", ILLEGAL_OPCODE, ILLEGAL_OPCODE,
@@ -1567,7 +1563,7 @@
UNPREDICTABLE/putstatic/, 1/getfield/, UNPREDICTABLE/putfield/,
UNPREDICTABLE/invokevirtual/, UNPREDICTABLE/invokespecial/,
UNPREDICTABLE/invokestatic/,
1/arraylength/, 1/athrow/, 1/checkcast/, 1/instanceof/, 1/monitorenter/,
1/monitorexit/, 0/wide/, UNPREDICTABLE/multianewarray/, 1/ifnull/, 1/ifnonnull/,
0/goto_w/, 0/jsr_w/, 0/breakpoint/, UNDEFINED, UNDEFINED,
@@ -1623,7 +1619,7 @@
0/dreturn/, 0/areturn/, 0/return/, UNPREDICTABLE/getstatic/, 0/putstatic/,
UNPREDICTABLE/getfield/, 0/putfield/, UNPREDICTABLE/invokevirtual/,
UNPREDICTABLE/invokespecial/, UNPREDICTABLE/invokestatic/,
1/arraylength/, 1/athrow/, 1/checkcast/, 1/instanceof/, 0/monitorenter/,
0/monitorexit/, 0/wide/, 1/multianewarray/, 0/ifnull/, 0/ifnonnull/,
0/goto_w/, 1/jsr_w/, 0/breakpoint/, UNDEFINED, UNDEFINED,
The text was updated successfully, but these errors were encountered: