Updating the circe dependency to 0.9-M2 #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated the circe dependency
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
=======================================
Coverage 67.71% 67.71%
=======================================
Files 8 8
Lines 254 254
Branches 3 3
=======================================
Hits 172 172
Misses 82 82
Continue to review full report at Codecov.
|
jeremyrsmith
requested changes
Nov 26, 2017
build.sbt
Outdated
| @@ -7,7 +7,7 @@ enablePlugins(TutPlugin) | |||
|
|
|||
| lazy val buildSettings = Seq( | |||
| organization := "io.github.finagle", | |||
| version := "0.3.1", | |||
| version := "0.3.2-snapshot", | |||
There was a problem hiding this comment.
Can you just change this to 0.3.2? Then we'll make a new release once it's merged.
Otherwise LGTM.
updated the snapshost to release version
|
done |
|
LGTM. Merging and will release shortly. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have updated circe dependency to
0.9.0-M2. This is a breaking change and so I have updated the main version to0.3.2-snapshot? (I am not sure on how to go about semantic versioning)changes seems to be minor.