Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTTP error message building #4

Merged
merged 1 commit into from
May 2, 2023
Merged

Conversation

pionl
Copy link
Contributor

@pionl pionl commented Feb 24, 2023

If connection fails then sometimes there is no message and code crashes.

error_get_last can return null. Today CNB API sometimes resets the connection and code crashes.

  • bug fix? yes/
  • new feature? no
  • BC break? no

If connection fails then sometimes there is no message and code crashes.
@pionl
Copy link
Contributor Author

pionl commented Apr 29, 2023

@filipsedivy any chance of merging? No pressure, thank you :)

@filipsedivy filipsedivy merged commit 175bbf1 into filipsedivy:master May 2, 2023
@filipsedivy
Copy link
Owner

Thanks for the fix, it's merged :)

@filipsedivy filipsedivy added the bug label May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants