-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix renaming files with long names in GridViewBrowser #898
Conversation
@yaichenbaum This PR changes selection view, is it acceptable? |
@yaichenbaum I'm having second thoughts on this: do you know if WrapPanel is virtualized? If it's not performance might be bad on large folders |
@gave92 Virtualization is very important, what if we built this off items repeater? |
I've read that in the latest version of Community Toolkit they rebuilt the WrapPanel to use items repeaters, but I'm not sure if that version is out yet. See here. Edit: it's in pre-release in version 6.1 Edit2: i'm taking this back as the solution is not viable due to WrapPanel not being virtualized |
c6e0425
to
a964a24
Compare
Ok I approached this differently. Solution: just use simple a popup with the TextBox @yaichenbaum I'm not using ItemsRepeater as you loose many features GridView gives you (e.g. Selection) |
Added x:Load attribute to edit popup
74db4b9
to
fe1d347
Compare
Can you share a screenshot of the new behavior? |
Looks good, does the reveal affect still work? |
The revel effect between the files/folders? Yes, I didn't have the mouse on the list in the screenshot |
I found a bug
|
The current app does the same thing. Can you confirm? |
@gave92 It can be done in a different PR. |
@gave92 Can you resolve the merge conflict? |
This PR fixes the issue with renaming files with long names when in GridViewBrowser. I'm using ListView + WrapPanel from windows community toolkit from instead of GridView.
Fixes #657