Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix creating a folder or file with restricted names or characters #933

Merged
merged 5 commits into from
Jun 7, 2020
Merged

Fix creating a folder or file with restricted names or characters #933

merged 5 commits into from
Jun 7, 2020

Conversation

tsvietOK
Copy link
Contributor

@tsvietOK tsvietOK commented Jun 7, 2020

Fixes #630
Fixes this

How it looks when user types restricted character:
image
The same in rename dialog:
image

yaira2
yaira2 approved these changes Jun 7, 2020
View reviewed changes
Files/Strings/en-US/Resources.resw Outdated Show resolved Hide resolved
Files/Strings/en-US/Resources.resw Outdated Show resolved Hide resolved
Files/Strings/en-US/Resources.resw Outdated Show resolved Hide resolved
@yaira2 yaira2 self-requested a review June 7, 2020 15:31
yaira2
yaira2 requested changes Jun 7, 2020
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the names of the strings as requested in the comments?

@yaira2 yaira2 added the changes requested Changes are needed for this pull request label Jun 7, 2020
@tsvietOK tsvietOK marked this pull request as ready for review June 7, 2020 15:40
@ghost ghost added the needs - code review label Jun 7, 2020
@tsvietOK tsvietOK marked this pull request as draft June 7, 2020 16:18
@tsvietOK tsvietOK marked this pull request as ready for review June 7, 2020 16:22
@tsvietOK tsvietOK requested a review from yaira2 June 7, 2020 17:09
@yaira2 yaira2 requested a review from lukeblevins June 7, 2020 17:35
@yaira2 yaira2 removed the changes requested Changes are needed for this pull request label Jun 7, 2020
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jun 7, 2020
@yaira2 yaira2 merged commit db79553 into files-community:master Jun 7, 2020
@tsvietOK tsvietOK deleted the rename-fix branch June 7, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeblevins lukeblevins lukeblevins approved these changes

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crashes when creating a folder or file with a restricted name
3 participants
@tsvietOK @lukeblevins @yaira2