Feature: Added "run" settings to properties window for shortcut files #16672
+94
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
reviewed
Jan 5, 2025
yaira2
reviewed
Jan 5, 2025
|
You can use SHOW_WINDOW_CMD from Windows.Win32.UI.WindowsAndMessaging namespace instead of ShowWindowCommand enum from Vanara. Casting should work. |
yaira2
reviewed
Jan 6, 2025
Comment on lines
+1841
to
+1843
| <data name="Run" xml:space="preserve"> | ||
| <value>Run</value> | ||
| </data> |
There was a problem hiding this comment.
It might be more user friendly to title the option as Start window.
There was a problem hiding this comment.
I agree that run is not really user friendly, but file explorer uses exactly the same word. Launch mode would also be an alternative, what do you think would be best?
There was a problem hiding this comment.
Let's go with Start window. It's true that File Explore uses this term, but we can do better 🙂
yaira2
added
needs - code review
and removed
changes requested
yaira2
reviewed
Jan 6, 2025
| { SHOW_WINDOW_CMD.SW_SHOWMINNOACTIVE, Strings.Minimized.GetLocalizedResource() }, | ||
| { SHOW_WINDOW_CMD.SW_MAXIMIZE, Strings.Maximized.GetLocalizedResource() } | ||
| }.AsReadOnly(); | ||
| public IReadOnlyDictionary<SHOW_WINDOW_CMD, string> ShowWindowCommandTypes { get => showWindowCommandTypes; } |
There was a problem hiding this comment.
Suggested change
| public IReadOnlyDictionary<SHOW_WINDOW_CMD, string> ShowWindowCommandTypes { get => showWindowCommandTypes; } | |
| public IReadOnlyDictionary<SHOW_WINDOW_CMD, string> ShowWindowCommandTypes { get => showWindowCommandTypes; } |
yaira2
reviewed
Jan 6, 2025
There was a problem hiding this comment.
Please add comments for the new properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Steps used to test these changes
Files_dia2qS407w.mp4