Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project: Rename 'Files.App (Package)' with 'Files.Package' #12475

Closed

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented May 28, 2023

Description

Motivation and Context

This dir name was made by microsoft upgrade assistant. The path should not contain symbols and spaces. I did not include unrelated changes.

  • Rename dir name with File Explorer
  • Update azure pipeline yml files
  • Update other reference path

Note
It takes about 3 minutes to load all diffs.

PR Checklist

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

Screenshots

None

@0x5bfa 0x5bfa changed the title Project: Project: Rename 'Files.App (Package)' with 'Files.Package' May 28, 2023
@hez2010
Copy link
Member

hez2010 commented May 28, 2023

We used to use Files.Package, but Files.App (Package) looks more like the package of Files.App, so we end up with the current name.
BTW Files.App (Package) is also the default name created by the official WinUI 3 template.
@yaira2 What do you think?

@0x5bfa
Copy link
Member Author

0x5bfa commented May 28, 2023

so we end up with the current name.

This folder name was created by the .NET Upgrade Assistant. And this PR is based on the previous suggest of project refactoring plan. People avoided to change folder, but to avoid using spaces & symbols, we must get rid of them.

PS, I renamed Files.Package with Files.App.Package

@0x5bfa
Copy link
Member Author

0x5bfa commented May 28, 2023

Failing Tests

@yaira2
Copy link
Member

yaira2 commented May 28, 2023

We discussed this a while ago and the conclusion was that it would be too disruptive with little benefit. The long-term plan is to remove the package project once it works to publish a package from single project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants