Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added "run" settings to properties window for shortcut files #16672

Merged

Conversation

marcofranzen99
Copy link
Contributor

Resolved / Related Issues

Steps used to test these changes

  • Updated the run settings in Files and compared with Windows File Explorer
Files_dia2qS407w.mp4

@yaira2 yaira2 added the changes requested Changes are needed for this pull request label Jan 5, 2025
@0x5bfa
Copy link
Member

0x5bfa commented Jan 6, 2025

You can use SHOW_WINDOW_CMD from Windows.Win32.UI.WindowsAndMessaging namespace instead of ShowWindowCommand enum from Vanara. Casting should work.

@yaira2 yaira2 added needs - code review and removed changes requested Changes are needed for this pull request labels Jan 6, 2025
yaira2
yaira2 previously approved these changes Jan 11, 2025
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2
Copy link
Member

yaira2 commented Jan 11, 2025

Can you please resolve the merge conflicts?

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jan 11, 2025
# Conflicts:
#	src/Files.App/Helpers/UI/UIFilesystemHelpers.cs
#	src/Files.App/Utils/Storage/Enumerators/Win32StorageEnumerator.cs
@yaira2
Copy link
Member

yaira2 commented Jan 12, 2025

Thank you!

@yaira2 yaira2 merged commit 8dcb100 into files-community:main Jan 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add "run" settings to properties window for shortcut files
3 participants