-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Added "run" settings to properties window for shortcut files #16672
Merged
yaira2
merged 4 commits into
files-community:main
from
marcofranzen99:16004_shortcut_run_settings
Jan 12, 2025
Merged
Feature: Added "run" settings to properties window for shortcut files #16672
yaira2
merged 4 commits into
files-community:main
from
marcofranzen99:16004_shortcut_run_settings
Jan 12, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
reviewed
Jan 5, 2025
yaira2
reviewed
Jan 5, 2025
You can use SHOW_WINDOW_CMD from Windows.Win32.UI.WindowsAndMessaging namespace instead of ShowWindowCommand enum from Vanara. Casting should work. |
yaira2
reviewed
Jan 6, 2025
yaira2
added
needs - code review
and removed
changes requested
Changes are needed for this pull request
labels
Jan 6, 2025
yaira2
reviewed
Jan 6, 2025
yaira2
reviewed
Jan 6, 2025
yaira2
previously approved these changes
Jan 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can you please resolve the merge conflicts? |
yaira2
added
ready to merge
Pull requests that are approved and ready to merge
and removed
needs - code review
labels
Jan 11, 2025
# Conflicts: # src/Files.App/Helpers/UI/UIFilesystemHelpers.cs # src/Files.App/Utils/Storage/Enumerators/Win32StorageEnumerator.cs
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Steps used to test these changes
Files_dia2qS407w.mp4