chore: setup TypeScript type checking #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
juliangruber
reviewed
May 3, 2024
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
|
@juliangruber added a few more commits to fix the remaining issue and address your comment. The PR is ready for final review and landing. |
juliangruber
reviewed
May 3, 2024
| @@ -2,6 +2,7 @@ import assert from 'node:assert' | |||
| import * as Sentry from '@sentry/node' | |||
| import { preprocess } from './lib/preprocess.js' | |||
| import { evaluate } from './lib/evaluate.js' | |||
| // TODO: implement typings - see https://github.com/filecoin-station/on-contract-event/issues/2 | |||
There was a problem hiding this comment.
I think we should switch to ethers@6 instead
juliangruber
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See space-meridian/roadmap#80
The content of
tsconfig.jsonis from station-core:https://github.com/filecoin-station/core/blob/01e9a9f6169c6df5dc152bf7d89b04bade3e5d70/tsconfig.json)
Out of scope/follow-up issues: