Removed unused metrics #154
Conversation
| @@ -324,92 +307,20 @@ func (p *pool) fetchResource(ctx context.Context, from *Node, resource string, m | |||
|
|
|||
| // trace-metrics | |||
| // request life-cycle metrics | |||
|
|
|||
| fetchRequestSuccessTimeTraceMetric.WithLabelValues(resourceType, getCacheStatus(isCacheHit), "tcp_connection").Observe(float64(result.TCPConnection.Milliseconds())) | |||
There was a problem hiding this comment.
do we not want this l1 breakdown timing anymore?
There was a problem hiding this comment.
@willscott It hasn't helped us with anything so far. We know where most time is spent on for hits/misses and we already have these same metrics on Saturn as well.
I think the e2e tracing work will be more helpful here.
There was a problem hiding this comment.
we want to be able to subtract it from overall request latency to separate out the L1 / caboose proportion from the lassie proportion in the long tail, right?
There was a problem hiding this comment.
Hmm, okay, no harm in keeping it then. I've put it back.
|
@willscott Can I merge ? |
|
waiting for visibility from @AmeanAsad when he wakes up, since it merge-conflicts with his in-progress PR to the same branch |
aarshkshah1992
changed the base branch from
feat/adaptive
to
aa/test-simulator
Removes metrics we no longer need as the backpressure PR has landed in main and some of those metrics were put in place to catch old bugs that no longer exist.