Stricter Linting #458
Stricter Linting #458
Conversation
Codecov Report
@@ Coverage Diff @@
## master #458 +/- ##
==========================================
+ Coverage 46.34% 46.56% +0.21%
==========================================
Files 40 40
Lines 4324 4304 -20
==========================================
Hits 2004 2004
+ Misses 2036 2017 -19
+ Partials 284 283 -1 |
| pending, err := adt.MakeEmptyMap(adt.AsStore(rt)).Root() | ||
| if err != nil { | ||
| rt.Abortf(exitcode.ErrIllegalState, "failed to create empty map: %v", err) | ||
| } | ||
|
|
||
| var st State | ||
| st.Signers = signers | ||
| st.Signers = params.Signers |
There was a problem hiding this comment.
Did the linter catch this? That's pretty impressive if it did.
There was a problem hiding this comment.
It caught a simpler thing which reminded me to do this here.
ZenGround0
force-pushed
the
fix/456
branch
2 times, most recently
from
af227ca
to
aea2338
Compare
| @@ -206,7 +206,7 @@ func TestVesting(t *testing.T) { | |||
| rt.SetCaller(anne, builtin.AccountActorCodeID) | |||
| rt.ExpectValidateCallerType(builtin.AccountActorCodeID, builtin.MultisigActorCodeID) | |||
| rt.ExpectAbort(exitcode.ErrInsufficientFunds, func() { | |||
| actor.propose(rt, darlene, abi.NewTokenAmount(100), builtin.MethodSend, fakeParams, nil) | |||
| _ = actor.propose(rt, darlene, abi.NewTokenAmount(100), builtin.MethodSend, fakeParams, nil) | |||
There was a problem hiding this comment.
FYI @anorth It felt confusing to use proposeOK and approveOK in ExpectAbort clauses that we know should fail so to get around linter's errcheck on the exitcode I explicitly throw away the exitcode value within these clauses. This seems better since we're communicating that we don't care what value we get, any is wrong.
|
@anorth merging now with the new |
* Don't skip linting builtin * Fix lint issues * Proper err str fmt * Review Response * errcheck propose/accept harness funcs * Don't do OK within expect abort Co-authored-by: ZenGround0 <ZenGround0@users.noreply.github.com>
Enabling strict linting in CI
To start with I'm temporarily adding in an intentional err drop to reproduce lint failure.
Closes #456